refactor(plugins): load OpenCode adapters from managed packages - #1525
Merged
limityan merged 1 commit intoJul 13, 2026
Merged
Conversation
Replace direct workspace scanning with validated fixed package input, isolate selected-package reads, and keep source approval separate from Host activation.
limityan
force-pushed
the
yanzhn/plugin-managed-package-host-input
branch
from
July 13, 2026 04:55
85faa10 to
840fa27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavior and boundaries
PluginPackageInputvalidates manifest/source identity, exact file set, per-file and package size limits, and hashes. It is self-consistent input, not an approval credential.Resource and code-size impact
Verification
cargo +nightly test -p bitfun-product-domains --test plugin_source_contracts --features plugin-source(7 passed)cargo +nightly test -p bitfun-services-integrations --no-default-features --features plugin-source plugin_source --lib(40 passed)cargo +nightly test -p bitfun-opencode-adapter(30 passed: 15 unit + 15 Host integration)node --test scripts/check-core-boundaries.test.mjs(3 passed)node scripts/check-core-boundaries.mjspnpm run check:repo-hygienecargo +nightly check --locked --workspace --exclude bitfun-cligit diff --checkThe workspace check retains pre-existing Windows
unsafe-op-in-unsafe-fnwarnings and introduces no new warning class.Independent review
Fresh isolated architecture/product and Rust security/performance reviewers audited the rebased full diff. Findings covering composition-root direction, empty projections, source-ID collisions, target-load isolation, retryable error semantics, misleading candidate documentation, and unnecessary reconciliation parameters were fixed. After the scope was explicitly limited to managed fixed input and read-only diagnostics, both reviewers reported no remaining P0/P1/P2 findings.